Add exp+linear fccd model for the Germanium detectors by giriPHM · Pull Request #162 · legend-exp/reboost

giriPHM · 2026-02-05T02:48:16Z

This is an effort to add the exponential + linear model for fccd. After talking with Toby, I realized that he was working on implementing the same model at the same time. We thought it would be a good idea to compare between our approaches to make sure that all the cases are well-handled.

For the parameters, fccd = 1, alpha =0.5, beta = 0.05, here is the output from my implementation overlayed with Toby's.

codecov · 2026-02-05T02:53:12Z

Codecov Report

❌ Patch coverage is 9.30233% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.98%. Comparing base (def9e9c) to head (bbdcdfb).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
src/reboost/math/functions.py	9.30%	39 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   70.00%   68.98%   -1.02%     
==========================================
  Files          33       33              
  Lines        2587     2631      +44     
==========================================
+ Hits         1811     1815       +4     
- Misses        776      816      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tdixon97 · 2026-02-05T11:11:13Z

Thanks @giriPHM some parts look improved compared to my implementation. But could you instead return ak.Array with units like in piecewise_linear_activeness?

Returning the results as ak.Array with attached units

src/reboost/math/functions.py

tdixon97 · 2026-02-06T00:30:43Z

Thanks @giriPHM for the nice contribution. It is similar to the open PR #162 but I think this implementation is a bit better and handles more cases.
I left a few very minor (mostly sylistic) comments. In addition, could you propose a name a bit more in line with other reboost processors (this should be call lower case for example we use piecewise_linear_activeness for the linear model).

I noticed you did not include any tests yet, I wrote some for #157 so maybe we can add them also here, if you want I can do this.

src/reboost/math/functions.py

Implementing the requested changes on the Excellent model for fccd

src/reboost/math/functions.py

tdixon97 · 2026-02-08T21:48:46Z

Nice work @giriPHM , you have some linting errors can you run pre-commit locally:

pre-commit run --all-files

and then fix the errors and add + commit + push the new files.

Similarly can you try to build the docs locally

cd docs
make

and fix the errors (probably just a empty line is needed after the math block)

Fix the errors from pre-commit and docs build

Changing the documentation as requested

* Add exp+lin fccd model for the Germanium detectors * style: pre-commit fixes * Returning the results as ak.Array and attaching units to them Returning the results as ak.Array with attached units * style: pre-commit fixes * Implementing the requested changes on the Excellent model for fccd. Implementing the requested changes on the Excellent model for fccd * style: pre-commit fixes * Fix errors from pre-commit and docs build Fix the errors from pre-commit and docs build * style: pre-commit fixes * Changing the documentation as requested Changing the documentation as requested --------- Co-authored-by: Shailesh Giri <gishai@Mac.lan> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shailesh Giri <gishai@Julietas-Laptop-3.local>

* Add exp+lin fccd model for the Germanium detectors * style: pre-commit fixes * Returning the results as ak.Array and attaching units to them Returning the results as ak.Array with attached units * style: pre-commit fixes * Implementing the requested changes on the Excellent model for fccd. Implementing the requested changes on the Excellent model for fccd * style: pre-commit fixes * Fix errors from pre-commit and docs build Fix the errors from pre-commit and docs build * style: pre-commit fixes * Changing the documentation as requested Changing the documentation as requested --------- Co-authored-by: giriPHM <94209767+giriPHM@users.noreply.github.com> Co-authored-by: Shailesh Giri <gishai@Mac.lan> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shailesh Giri <gishai@Julietas-Laptop-3.local>

Shailesh Giri and others added 2 commits February 4, 2026 21:33

Add exp+lin fccd model for the Germanium detectors

0901f2b

style: pre-commit fixes

8b2db76

Shailesh Giri and others added 2 commits February 5, 2026 11:51

Returning the results as ak.Array and attaching units to them

c881a1c

Returning the results as ak.Array with attached units

style: pre-commit fixes

80ccfe8

tdixon97 reviewed Feb 6, 2026

View reviewed changes